Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distributor: add logs to flaky TestDistributor_Push_ShouldSupportWriteBothToIngestersAndPartitions #9323

Merged

Conversation

dimitarvdimitrov
Copy link
Contributor

What this PR does

I suspect the 1s timeout can expire in CI. Let's inspect kafka in CI to check if that's the case or we have a bug.

Which issue(s) this PR fixes or relates to

Related to #9299

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

…eBothToIngestersAndPartitions

I suspect the 1s timeout can expire in CI. Let's inspect kafka in CI to check if that's the case or we have a bug.

Signed-off-by: Dimitar Dimitrov <[email protected]>
@dimitarvdimitrov dimitarvdimitrov requested a review from a team as a code owner September 18, 2024 14:50
Signed-off-by: Dimitar Dimitrov <[email protected]>
Copy link
Contributor

@gotjosh gotjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dimitarvdimitrov dimitarvdimitrov merged commit 3c4f00e into main Sep 20, 2024
29 checks passed
@dimitarvdimitrov dimitarvdimitrov deleted the dimitar/distributor/pushing-to-kafka-flaky-test branch September 20, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants