gRPC: Support S2 compression #9322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
force-pushed
the
arve/grpc-s2
branch
from
f98ac71
to
0f15b7c
Compare
aknuds1
force-pushed
the
arve/grpc-s2
branch
4 times, most recently
from
833b840
to
d72a6ac
Compare
aknuds1
requested review from
stevesg,
grafanabot,
a team and
tacole02
as code owners
deniszh
approved these changes
Sep 19, 2024
aallawala
approved these changes
Sep 19, 2024
aknuds1
force-pushed
the
arve/grpc-s2
branch
3 times, most recently
from
99502b7
to
bc0ea78
Compare
|
Dropping the Snappy compatible mode, since I don't see a use for it in practice. AFAICT for it to be at all useful, it has to replace the Snappy compressor (same name). When using the "s2-snappy" compressor name, unpatched Mimir instances don't recognize it and fail to accept the connection. |
aknuds1
force-pushed
the
arve/grpc-s2
branch
from
56ecc92
to
c9a3d50
Compare
pstibrany
approved these changes
Sep 25, 2024
| @@ -76,6 +77,7 @@ func (cfg *Config) RegisterFlags(f *flag.FlagSet, logger log.Logger) { | |||
| f.StringVar(&cfg.Addr, "query-frontend.instance-addr", "", "IP address to advertise to the querier (via scheduler) (default is auto-detected from network interfaces).") | |||
| f.IntVar(&cfg.Port, "query-frontend.instance-port", 0, "Port to advertise to querier (via scheduler) (defaults to server.grpc-listen-port).") | |||
|
|
|||
| cfg.GRPCClientConfig.CustomCompressors = []string{s2.Name} | |||
There was a problem hiding this comment.
uh, so we need to pass this to all clients? I somehow thought it would be enough to register it in dskit "globally".
There was a problem hiding this comment.
Maybe we can find a better solution after this PR?
Support S2 and S2 in Snappy compatible mode gRPC compression. Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
aknuds1
force-pushed
the
arve/grpc-s2
branch
from
39ce34d
to
b646eb8
Compare
|
Yes
Ср, 25 сент. 2024 г. в 17:12, Arve Knudsen ***@***.***>:
… ***@***.**** commented on this pull request.
------------------------------
In pkg/util/grpcencoding/s2/s2.go
<#9322 (comment)>:
> @@ -0,0 +1,88 @@
+// SPDX-License-Identifier: AGPL-3.0-only
+// Provenance-includes-location: https://github.com/mostynb/go-grpc-compression/blob/f7e92b39057ca421a6485f650243a3e804036498/internal/s2/s2.go
+// Provenance-includes-license: Apache-2.0
+// Provenance-includes-copyright: Copyright 2022 Mostyn Bramley-Moore.
+
+// Package s2 is an experimental wrapper for using
+// github.com/klauspost/compress/s2 stream compression with gRPC.
+package s2
Aha, so basically you prefer option 1: Just copy into Mimir without
retaining any copyright? Just so we're 100% clear :)
—
Reply to this email directly, view it on GitHub
<#9322 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJLTVUECIWJZV6KEYIUSPTZYLHFZAVCNFSM6AAAAABON2MKLKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMRYGU4TOOBRGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Thanks, added your tests/benchmarks. |
Signed-off-by: Arve Knudsen <[email protected]>
aknuds1
force-pushed
the
arve/grpc-s2
branch
from
85191fd
to
c866870
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Support S2 (a Snappy extension) gRPC compression, via custom gRPC compressor support in dskit.
Based on grafana/dskit#583.
I've done a test deployment internally, and everything seems to work.
See favourable test results vs Snappy.
Which issue(s) this PR fixes or relates to
Supersedes #9292. Fixes #8522.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.