Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruler: Make the sync queue polling intervals configurable. #9268

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

stevesg
Copy link
Contributor

@stevesg stevesg commented Sep 11, 2024

In some environments, it may be desirable to trade off increased resource usage for faster rule group updates.

  • For the outbound queue - polling more often results in more gRPC calls to other rulers, but nothing else. I think reducing this below 10s could be valuable.
  • For the inbound queue - polling more often results in more rule sync operations, which can be quite expensive for tenants with many rule groups. Reducing this is likely not a wise idea.

In a follow up PR, I want to experiment with making the sync operations more specific (e.g. include rule group), this would potentially allow more frequent inbound queue polling.

Part of #9329

@stevesg stevesg force-pushed the stevesg/sync-queue-poll-intervals branch from 4255161 to fed31ba Compare September 11, 2024 09:49
@stevesg stevesg marked this pull request as ready for review September 11, 2024 10:30
@stevesg stevesg requested review from a team and tacole02 as code owners September 11, 2024 10:30
Copy link
Contributor

@gotjosh gotjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gotjosh
Copy link
Contributor

gotjosh commented Sep 12, 2024

Remember to modify the about versioning documentation.

Copy link
Contributor

@tacole02 tacole02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants