Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): add image registry value for memcached and memcached-exporter #16511

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MagnusRef
Copy link

What this PR does / why we need it:

Adds Docker image registry value for memcached and memcached-exporter. This is done to be able to specify custom registries for memcached and memcached-exporter.

Also adds some missing reference descriptions for memcached-exporter image values.

Which issue(s) this PR fixes:
Fixes #16197

Special notes for your reviewer:

First time contributing, so sorry if anything is missing. :)

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@MagnusRef MagnusRef requested a review from a team as a code owner February 28, 2025 22:37
@CLAassistant
Copy link

CLAassistant commented Feb 28, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added area/helm type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories labels Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm size/M type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No registry entry for memcached and memcachedExporter in values.yaml file
2 participants