Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parameterise the IAMRoleName for lambda-promtail CloudFormation template-eventbridge #16495

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nishioka-shinji
Copy link

@nishioka-shinji nishioka-shinji commented Feb 28, 2025

What this PR does / why we need it:
In our project, when attempting to create multiple lambda-promtail instances using tools/lambda-promtail/template-eventbridge.yaml, we encountered an issue with duplicate IAM role names. This modification is necessary to resolve that problem.

Which issue(s) this PR fixes:
Adds a parameter to specify the IAMRoleName in the lambda-promtail template-eventbridge template.

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@nishioka-shinji nishioka-shinji requested a review from a team as a code owner February 28, 2025 01:46
@CLAassistant
Copy link

CLAassistant commented Feb 28, 2025

CLA assistant check
All committers have signed the CLA.

@nishioka-shinji nishioka-shinji changed the title parameterise iam role name feat: parameterise the IAMRoleName for lambda-promtail CloudFormation template-eventbridge Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants