Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mixin): Allow regex filter for log level label #16493

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

naing2victor
Copy link

What this PR does / why we need it:
Allow regex filter on log level label because variables selector dropdown has multi-select option enabled. Regex filter for log level label is also used in helm dashboard

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@naing2victor naing2victor requested a review from a team as a code owner February 27, 2025 20:07
@CLAassistant
Copy link

CLAassistant commented Feb 27, 2025

CLA assistant check
All committers have signed the CLA.

@trevorwhitney
Copy link
Collaborator

have you done any benchmarks here? regex will be slower so I'd like to make sure I fully understand the use case, mind providing a few screenshots and brief explanation of your flow?

@naing2victor
Copy link
Author

@trevorwhitney I don't have specific use case for this. Since i found regex is used for log level label in helm dashboard and i thought if we want to make it standard across the repo. We can set multi-value selector disable, so that Log Rate and Logs panel will show proper result. Right now if user select multiple options for log level, above 2 panels will not show data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants