Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(policies): Support global policy #16439

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

salvacorts
Copy link
Contributor

@salvacorts salvacorts commented Feb 25, 2025

What this PR does / why we need it:

This PR implements global policies that are applied to all streams (regardless of their stream<>policy mappings).

  • For enforced labels: the global policy labels is appended to the named policy label if the stream matches a named policy. Otherwise only the global policy labels will be enforced if any.
  • For blocked ingestion:
    • If the mapped policy is empty, the global policy block is applied (if exists).
    • If the mapped policy is not empty, the stream will be blocked only if there is a matching named policy block

E.g. If we have

block_ingestion_policy_until:
   "*": <eod>
   policy1: <eod>
  • stream not matching any policy --> will be blocked due to global policy
  • stream matching policy1 --> will be blocked due to policy1 policy
  • stream matching policy2 --> won't be blocked since there is no block entry for policy2

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Feb 25, 2025
Copy link
Contributor

github-actions bot commented Feb 25, 2025

@salvacorts salvacorts marked this pull request as ready for review February 25, 2025 15:20
@salvacorts salvacorts requested a review from a team as a code owner February 25, 2025 15:20
Copy link
Contributor

@DylanGuedes DylanGuedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants