-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(logql): Add LogQL Benchmark Suite #16434
Open
cyriltovena
wants to merge
30
commits into
grafana:main
Choose a base branch
from
cyriltovena:bench-logql-dataobj
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase struct and GenerateTestCases public for reuse, add Name() and Description() methods, sort test cases by name, simplify output format
…ce, and multi-store support - Add determinism test for log generator to ensure consistent dataset generation - Implement config save/load functionality for generator configuration - Modify Builder to support multiple stores and save generator config - Update Generator to use configurable seed for reproducibility - Add default seed and configuration options to improve generator flexibility
- Fix list view being cut off when returning from run view - Ensure proper window size handling during view transitions - Maintain viewport dimensions when switching between views - Add proper cleanup and reinitialization of views - Improve list view refresh to maintain state and dimensions - Fix buffer refresh issues with tea.ClearScreen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a comprehensive benchmark suite for LogQL, Loki's query language. The suite is designed to help measure and improve the performance of LogQL queries by providing tools to generate realistic log data and benchmark various query patterns against different storage implementations.
What this PR does
pkg/logql/bench/
Why this is valuable
This benchmark suite will help:
Key features
How to use it
make -C pkg/logql/bench generate
make -C pkg/logql/bench run
pkg/logql/bench/
Future improvements
CLI
This PR comes with a a CLI tools to select which benchmark to run, compare result, re-run and see performance profiles.
To use it run
make run