Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scheduler): implement and register block builder rpc service #15248

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ashwanthgoli
Copy link
Contributor

What this PR does / why we need it:

  • Block scheduler is updated to implement BlockBuilderServiceServer rpc interface and registered with grpc server.
  • GetJob is now a server-side streaming rpc which allows builders to wait on the server for pending jobs.
  • JobQueue uses a cond var to wake up pending routines if there are any new pending jobs

minor improvements:

  • uses int32 for partition field in types.Job to maintain consistency
  • updates loadRecords to return any backoff errors

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant