feat(blockbuilder): consolidate on record counting planner #15247
+247
−164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-d
force-pushed
the
blockbuilder-record-count-strategy-update
branch
from
09d18d8
to
2b2bdd9
Compare
github-actions
bot
added
the
type/docs
owen-d
force-pushed
the
blockbuilder-record-count-strategy-update
branch
from
2b2bdd9
to
99ea603
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #15245.
This simplifies and consolidates planner implementation to just
RecordCountStrategywhile adding more parsing logic and the scaffolding to easily create new strategies in the future.