Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pass down reader metrics to avoid duplicate registration #15246

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

ashwanthgoli
Copy link
Contributor

What this PR does / why we need it:
Partition readers can be instantiated multiple times once per each consumer. But this would cause panics as a result of duplicate reader metric registration. This pr updates the constructor to allow callers to pass down metrics.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@ashwanthgoli ashwanthgoli requested a review from a team as a code owner December 4, 2024 07:47
@ashwanthgoli ashwanthgoli merged commit d59a5e2 into main Dec 4, 2024
60 checks passed
@ashwanthgoli ashwanthgoli deleted the reader-metrics branch December 4, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants