-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove files for legacy docs #1832
base: main
Are you sure you want to change the base?
Conversation
@jdbaldry would you mind taking a look at this? I just want to make sure I don't remove any files that we need for the repo to work correctly with the Grafana docs. 😅 Also, would it be hard to add a workflow to make sure the repo builds correctly? |
There's a lot of deletions so it's a bit hard to know but I guess you're primarily interested in being able to run You can get a deploy preview if you make some trivial change to the For CI, we check the docs build in the website before publishing: https://github.com/grafana/writers-toolkit/blob/main/publish-technical-documentation/action.yml#L22C1-L26C1. I can extract that step into a reusable workflow and add it to the CI for PRs in this repo if you'd like? |
I just realized it's 4000+ file deletions 😅😅. I think looking at the file structure in the local branch is easier to see what it's still there, but yeah, I think we just need to make sure If we could add a workflow to check the docs build, and the deploy preview, that'd be awesome. 😄 |
🎉 #1840 🎉 |
What?
Remove the files for the legacy version of the k6 docs.
Checklist
npm start
command locally and verified that the changes look good.Related PR(s)/Issue(s)
Closes #1824.