[tempo] Add servicemonitor namespace and values note #3506
Merged
+24
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviderli614
requested review from
Sheikh-Abubaker,
dgzlopes,
swartz-k,
BitProcessor,
faustodavid and
a team
as code owners
|
|
daviderli614
force-pushed
the
chore/tempo-config
branch
from
b5f20ed to
f6c419b
Compare
Sheikh-Abubaker
requested changes
Jan 12, 2025
Sheikh-Abubaker
requested changes
Jan 12, 2025
Signed-off-by: liyang <[email protected]>
Signed-off-by: liyang <[email protected]>
daviderli614
force-pushed
the
chore/tempo-config
branch
from
1aaf453 to
f5798a4
Compare
Signed-off-by: liyang <[email protected]>
daviderli614
force-pushed
the
chore/tempo-config
branch
from
f5798a4 to
f92f2cd
Compare
|
Hi @Sheikh-Abubaker |
Signed-off-by: Sheikh-Abubaker <[email protected]>
Sheikh-Abubaker
approved these changes
Jan 15, 2025
joe-elliott
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ServiceMonitor does not have a namespace specified, need to define namespace.
Add tempo values comments and document link can help users configure better.