Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable OCI chart push #2443

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Enable OCI chart push #2443

merged 1 commit into from
Jun 22, 2023

Conversation

jkroepke
Copy link
Collaborator

@jkroepke jkroepke commented Jun 3, 2023

Fixes #2395

This PR start to publish OCI helm charts to ghcr.io/grafana/charts/, e.g. : ghcr.io/grafana/charts/grafana

Bitnami recently switches to OCI as default source for helm charts

and prometheus-community enable OCI based helm charts, too:

Fetch charts over OCI has multiple benefits:

  • It's not longer necessary to download the 1.6M chart index.yaml each time.
  • Mirroring to air-gapped environments would much easier, since existing service like Azure Container Registry, Elastic Container Registry and GoHarbor can be used to store/cache the helm charts.

I'm aware that this PR might be a bit aggressive, but I also would like to trigger the discussion here. As I know, this needs to be done at the loki chart, too.

@jkroepke jkroepke requested a review from a team as a code owner June 3, 2023 08:35
Signed-off-by: Jan-Otto Kröpke <[email protected]>
@jkroepke
Copy link
Collaborator Author

@grafana/helm-charts-admins what did you thing?

@zanhsieh
Copy link
Collaborator

@jkroepke
I think they need to set up grafana owned ghcr account and put it in Settings > Secerts and variables > Actions > Repository secrets.

@jkroepke
Copy link
Collaborator Author

@zanhsieh No. The GITHUB_TOKEN from the gh actions is sufficient. No additional account is needed.

@zanhsieh zanhsieh merged commit 8d26baa into grafana:main Jun 22, 2023
@jkroepke jkroepke deleted the oci-chart-push branch June 22, 2023 17:13
@zanhsieh
Copy link
Collaborator

zanhsieh commented Jun 22, 2023

@jkroepke
Got this on release workflow message:

https://github.com/grafana/helm-charts/actions/runs/5348497649/jobs/9698442262

Run shopt -s nullglob
Error: failed to authorize: failed to fetch anonymous token: unexpected status from GET request to https://ghcr.io/token?scope=repository%3Agrafana%2Fcharts%2Ftempo-distributed%3Apull&scope=repository%3Agrafana%2Fcharts%2Ftempo-distributed%3Apull%2Cpush&service=ghcr.io: 403 Forbidden
Error: Process completed with exit code 1.

If we can't fix it, please consider another PR to rollback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide charts through OCI registry
2 participants