database_observability: use TiDB parser for parsing query samples #2807
+194
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristiangreco
force-pushed
the
cristian/dbo11y-tidb-parser
branch
2 times, most recently
from
f523ffe to
7929eef
Compare
cristiangreco
commented
Feb 28, 2025
Comment on lines
-34
to
-38
| v1.7.1 | ||
| ----------------- | ||
|
|
There was a problem hiding this comment.
Moving this entry as the change "better handling of truncated queries" was not included in 1.7.1.
cristiangreco
commented
Feb 28, 2025
Comment on lines
+59
to
+60
| // TODO(cristian): experimental, will be removed soon | ||
| UseTiDBParser bool `alloy:"use_tidb_parser,attr,optional"` |
There was a problem hiding this comment.
This will be undocumented because it's temporary.
cristiangreco
requested review from
matthewnolf,
fridgepoet and
a team
as code owners
Add a new experimental option to use the TiDB parser for parsing query.
cristiangreco
force-pushed
the
cristian/dbo11y-tidb-parser
branch
from
7929eef to
1a8ae1e
Compare
fridgepoet
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add a new experimental option to use the TiDB parser for parsing query.
Which issue(s) this PR fixes
n.a.
Notes to the Reviewer
PR Checklist