Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented import dashboards from a directory #26

Closed
wants to merge 15 commits into from

Conversation

vrymar
Copy link
Contributor

@vrymar vrymar commented Oct 8, 2024

Solution for issue #25.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 54 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@fbf4026). Learn more about missing BASE report.

Files with missing lines Patch % Lines
grafana_import/cli.py 0.00% 42 Missing ⚠️
grafana_import/grafana.py 0.00% 6 Missing ⚠️
grafana_import/util.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage        ?   19.73%           
=======================================
  Files           ?        5           
  Lines           ?      446           
  Branches        ?        0           
=======================================
  Hits            ?       88           
  Misses          ?      358           
  Partials        ?        0           
Flag Coverage Δ
unittests 19.73% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amotl
Copy link
Contributor

amotl commented Oct 15, 2024

Also thanks for this excellent improvement, Vitalii. Can you also reformat the code to satisfy CI, like you did with your other patch?

@vitaliirymar
Copy link
Contributor

Will do tomorrow

@vrymar
Copy link
Contributor Author

vrymar commented Oct 16, 2024

Hi @amotl ! Not sure why export tests are failing, as this functionality was not touched. Checking...

@amotl
Copy link
Contributor

amotl commented Oct 16, 2024

Maybe you need to rebase your branch on top of main? If you can't manage to make CI succeed, I can also have a look later to support you.

@vrymar
Copy link
Contributor Author

vrymar commented Oct 16, 2024

Closing this PR and creating a new one rebased on upstream/main

@vrymar vrymar closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants