Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add show_label check to gr.Dataframe #7283

Merged
merged 4 commits into from
Feb 2, 2024
+48 −1
Merged

Add show_label check to gr.Dataframe #7283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9d87c20
add show_label check and story test
hannahblair Feb 2, 2024
20a47eb
add changeset
gradio-pr-bot Feb 2, 2024
591f273
formatting
hannahblair Feb 2, 2024
0c63f36
Merge branch 'dataframe-label' of https://github.com/gradio-app/gradi…
hannahblair Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/blue-walls-poke.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@gradio/dataframe": patch
"gradio": patch
---

fix:Add `show_label` check to `gr.Dataframe`
38 changes: 38 additions & 0 deletions js/dataframe/Dataframe.stories.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,44 @@
}}
/>

<Story
name="Interactive dataframe with label"
args={{
value: {
data: [
["Cat", 5],
["Horse", 3],
["Snake", 1]
],
headers: ["Animal", "Votes"],
metadata: null
},
label: "Animals",
show_label: true,
col_count: [2, "dynamic"],
row_count: [3, "dynamic"]
}}
/>

<Story
name="Interactive dataframe no label"
args={{
value: {
data: [
["Cat", 5],
["Horse", 3],
["Snake", 1]
],
headers: ["Animal", "Votes"],
metadata: null
},
label: "Animals",
show_label: false,
col_count: [2, "dynamic"],
row_count: [3, "dynamic"]
}}
/>

<Story
name="Static dataframe"
args={{
Expand Down
2 changes: 2 additions & 0 deletions js/dataframe/Index.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
export let col_count: [number, "fixed" | "dynamic"];
export let row_count: [number, "fixed" | "dynamic"];
export let label: string | null = null;
export let show_label = true;
export let wrap: boolean;
export let datatype: Datatype | Datatype[];
export let scale: number | null = null;
Expand Down Expand Up @@ -95,6 +96,7 @@
<Table
{root}
{label}
{show_label}
{row_count}
{col_count}
{value}
Expand Down
3 changes: 2 additions & 1 deletion js/dataframe/shared/Table.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

export let datatype: Datatype | Datatype[];
export let label: string | null = null;
export let show_label = true;
export let headers: Headers = [];
let values: (string | number)[][];
export let value: { data: Data; headers: Headers; metadata: Metadata } | null;
Expand Down Expand Up @@ -643,7 +644,7 @@
/>

<div class:label={label && label.length !== 0} use:copy>
{#if label && label.length !== 0}
{#if label && label.length !== 0 && show_label}
<p>
{label}
</p>
Expand Down
Loading