Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to remove line number using show_line_numbers in gr.Code() #10627

Closed

Conversation

Nivedithabp
Copy link

@Nivedithabp Nivedithabp commented Feb 19, 2025

Description

Option to remove line number in gr.Code()

Closes: #10557

import gradio as gr

code_snippet = """def hello_world():
    print("Hello, World!")"""

with gr.Blocks() as demo:
    gr.Code(code_snippet, language="python" , show_line_numbers=False)  # option to hide line numbers

demo.launch()

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Testing and Formatting Your Code

  1. PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests: bash scripts/run_backend_tests.sh

  2. Please run these bash scripts to automatically format your code: bash scripts/format_backend.sh, and (if you made any changes to non-Python files) bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Feb 19, 2025

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/d04f962f8ad93a95b089a5bb315d6253f49766d5/gradio-5.16.1-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@d04f962f8ad93a95b089a5bb315d6253f49766d5#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/d04f962f8ad93a95b089a5bb315d6253f49766d5/gradio-client-1.12.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/d04f962f8ad93a95b089a5bb315d6253f49766d5/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/code minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Option to remove line number using show_line_numbers in gr.Code()

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs
Copy link
Member

Hi @Nivedithabp thanks for addressing this but this does not work. For example, the demo that you updated still shows line numbers:

image

Also, this PR bears signs of an LLM-generated PR, e.g. this change, which doesn't really make sense:

    def api_info(self) -> dict[str, Any]:
        return {
            "type": "string",
            "show_line_numbers" : self.show_line_numbers,
            }

I'm going to close this. Please see our contributing guidelines which state that LLM-generated PRs are not acceptable

@abidlabs abidlabs closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to remove line numbers in gr.Code
3 participants