Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make note about MX_BUILD_EXPLODED conditional on it not being true #280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smarr
Copy link
Collaborator

@smarr smarr commented Jan 30, 2024

This is really a very minor things, though, every time I do a mx eclipseinit and it reminds me of MX_BUILD_EXPLODED, I spend a few minutes figuring out whether I got the config wrong.

By adding the check, the note is only printed when the configuration is something other than MX_BUILD_EXPLODED=true.

This is really a very minor things, though, every time I do a `mx eclipseinit` and it reminds me of MX_BUILD_EXPLODED, I spend a few minutes figuring out whether I got the config wrong.

By adding the check, the note is only printed when the configuration is something other than `MX_BUILD_EXPLODED=true`.

Signed-off-by: Stefan Marr <[email protected]>
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 30, 2024
@smarr
Copy link
Collaborator Author

smarr commented Jan 30, 2024

Hm, actually, I can't make anything work with MX_BUILD_EXPLODED=true set. Neither my own language nor GraalPy. All break with different issues. Some Java module issue or some dynamic library issue on GraalPy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant