Repository navigation
sample_mask input: allow either full coverage mask or (1<<sample_index) - #4671
Merged
Merged
Conversation
alan-baker
approved these changes
Jun 21, 2026
alan-baker
left a comment
alan-baker
left a comment
Contributor
There was a problem hiding this comment.
I asked myself if a particular device must have all invocations be one answer or the other and I think the answer is no.
This allows the varying behaviour observed on different platforms. Generalize the "findFailedPixels" utility to allow two reference "expected" texel views. A pixel comparison succeeds if the "actual" texel matches the texel from either of the "expected" or the "alternate expected" texel views. See gpuweb/gpuweb#5457 Co-authored-by: alan-baker <alanbaker@google.com>
dneto0
force-pushed
the
sample-mask-either-behaviour
branch
from
June 22, 2026 13:23
0fd4154 to
840902c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the varying behaviour observed on different platforms.
Generalize the "findFailedPixels" utility to allow two reference "expected" texel views. A pixel comparison succeeds if the "actual" texel matches the texel from either of the "expected" or the "alternate expected" texel views.
See gpuweb/gpuweb#5457
Issue: #
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.