Skip to content

Conversation

@greggman
Copy link
Contributor


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located in the test tree.
  • Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

@greggman
Copy link
Contributor Author

CQ run 🤞

@greggman
Copy link
Contributor Author

note: there a large list of TODOs in this file.

For example, I'd expect it's possible that resolving to a slice of a 3d texture is broken somewhere. I started to try to add that but it was going to be a bit of work. This was a smaller change.

Copy link
Collaborator

@beaufortfrancois beaufortfrancois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beaufortfrancois
Copy link
Collaborator

CQ is not happy sadly ;(

@greggman
Copy link
Contributor Author

sadly those appear to be real driver bugs :(

@greggman greggman merged commit 9ad7259 into gpuweb:main Dec 11, 2025
1 check passed
@greggman greggman deleted the resolve-more-formats branch December 11, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants