Repository navigation
fix(make): run tests via uv so make test works without a preinstalled pytest - #112
Merged
Merged
Conversation
… pytest pytest is not a documented prerequisite, so on a clean system python3 'make test' failed with 'No module named pytest'. uv is a required dependency, and CI already runs the suite with 'uv run --with pytest'. Git-Session-Id: 29f3abee-954d-41b0-977a-d10bc92c57b8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found during a fresh-clone onboarding run (commit c7fd8b9, Linux x86_64, Python 3.12.3, uv 0.13.4).
On a clean
PATH(env -i PATH=/usr/bin:/bin),make testfails:pytest is not listed in the README prerequisites, but
uvis a required dependency, and CI already runs the suite withuv run --with pytest(.github/workflows/test.yml). This change makesmake testuse the same mechanism.After the change, with the same clean
PATH:make testpasses 11 tests in 6.3s.