Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

[WIP] Separate and simplify deployment #307

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

azerella
Copy link
Contributor

@azerella azerella commented Nov 9, 2018

This PR is quite controversial as it refactors the project structure. Currently the web client is deployed using a very simple express server and is coupled to this for the search functionality, by introducing a microservice model we can decouple these two modules and have them as seperate deployments.

Pros:

  • Enables isolated deployments of static files with a real web server like nginx or apache.
  • Offers plug n' play functionality of the search api and web client, this workflow could make introducing the concept of a more popular CMS such as Gatsby.js easier.
  • Isolated tests between search and static site modules
  • Improved web security ( i.e Express.js was never really designed to be a production ready server, and writing servers in general is not a good solution ).
  • Improved web performance ( i.e nginx offers gzip compression of static assets )

Cons:

  • Potentially might make the project feel more complicated than it needs to be.
  • A large refactor like this will take a considerable amount of time.

Ideas / Options:

  • Integrate a static search library like http://elasticlunr.com/ or https://lunrjs.com/ which would void the need for this model, this would need to be throughly tested in older browsers and potentially hasn't been done before.

Demo functionality on how web-client talks to search-api
@azerella azerella added enhancement New feature or request. help wanted Extra attention is needed. submitted by user Issues on behalf of users. labels Nov 9, 2018
@azerella azerella force-pushed the develop branch 4 times, most recently from 745b154 to 607c8ec Compare November 12, 2018 03:03
Deleted unused content folder for search-api
@alex-page
Copy link
Contributor

alex-page commented Nov 22, 2018

I am going to move this back into the backlog as we have some other priorities right now. I think there is a lot of potential here 👍

@alex-page
Copy link
Contributor

Simplify 🤔

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request. help wanted Extra attention is needed. submitted by user Issues on behalf of users.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants