-
Notifications
You must be signed in to change notification settings - Fork 0
feat: soft delete by ID #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
9a4e50a
to
19d274c
Compare
458dd5f
to
86a5a39
Compare
Pull Request Test Coverage Report for Build 15287397780Details
💛 - Coveralls |
@@ -22,8 +22,10 @@ type Repository interface { | |||
GetTypes(ctx context.Context, flt Filter) (map[Type]int, error) | |||
Upsert(ctx context.Context, ast *Asset) (string, error) | |||
UpsertPatch(ctx context.Context, ast *Asset, patchData map[string]interface{}) (string, error) | |||
DeleteByID(ctx context.Context, id string) error | |||
DeleteByID(ctx context.Context, id string) (string, error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead introduce new method SoftDelete*
, let's keep using the existing one, will override the behavior to soft delete, hard deletion will come later on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I plan to create new MR to delete Delete* method, to avoid confusion on reviewing too.
And to easily revert from that MR if turns out that any Delete* needed
any concern about that mas?
No description provided.