Skip to content

Conversation

@eternal-flame-AD
Copy link
Member

@eternal-flame-AD eternal-flame-AD commented Oct 16, 2025

Closes #862 .

I removed the manual column fixup: The default column type is already bloba and longblob (I tested on the docker container for MariaDB and postgres).

I also dropped a test that is basically if the database returns error then the function has to return an error, feels a little mechanical coverage driven test not really useful.

@eternal-flame-AD eternal-flame-AD requested a review from a team as a code owner October 16, 2025 06:13
@codecov
Copy link

codecov bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.14%. Comparing base (6de7720) to head (d9509a2).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
database/database.go 75.75% 6 Missing and 2 partials ⚠️
database/ping.go 50.00% 1 Missing and 1 partial ⚠️
runner/runner.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #863      +/-   ##
==========================================
+ Coverage   78.76%   79.14%   +0.38%     
==========================================
  Files          56       56              
  Lines        2670     2225     -445     
==========================================
- Hits         2103     1761     -342     
+ Misses        476      360     -116     
- Partials       91      104      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: eternal-flame-AD <[email protected]>
Signed-off-by: eternal-flame-AD <[email protected]>
Copy link
Member

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I'll try to test this with all supported databases on sunday, or next week.

Signed-off-by: eternal-flame-AD <[email protected]>
@eternal-flame-AD
Copy link
Member Author

I checked the unique index now generates correctly on postgres. Thanks for the catch. The primary key one doesn't look super actionable right now, the current behavior looks fine to me (migrate the foreign key to a supertype but keep primary key as is on an existing DB)

Copy link
Member

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

postgres and sqlite looks good, but mysql/mariadb has some problems.

Signed-off-by: eternal-flame-AD <[email protected]>
Signed-off-by: eternal-flame-AD <[email protected]>
Copy link
Member

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:, please squash the commits.

@eternal-flame-AD eternal-flame-AD merged commit 496c166 into master Oct 29, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Migrate github.com/jinzhu/gorm to gorm.io/gorm

3 participants