Open
Conversation
To make the setup.py file compliant with Debian and Ubuntu package creation, we should avoid using the Readme as the long description. Using it, makes Lintian fail really hard, and also breaks some guidelines that suggest not to use that long descriptions. Because of that, I deleted the line that adds the README, and modified the long description with the tentative text "Autoscripting Python for your presentations". Here, if the pull request is accepted, the author should define a proper Long Description for AutoPython. After this change, and the 8 spaces instead of the tabs proposed earlier, lintian passess all the tests, which is absolutely good for the package to - someday - being accepted in Debian and Ubuntu. The output of lintian is ( after this fixes ) : juan@beq:~/code/autopython-0.7-b1/deb_dist$ lintian python3-autopython_0.7-1_all.deb W: python3-autopython: new-package-should-close-itp-bug W: python3-autopython: binary-without-manpage usr/bin/autoipython3 W: python3-autopython: binary-without-manpage usr/bin/autopython3 Of course the first should be ignored, while number two and three are related to man pages that are not yet available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make the setup.py file compliant with Debian and Ubuntu package creation, we should avoid using the Readme as the long description. Using it, makes Lintian fail really hard, and also breaks some guidelines that suggest not to use that long descriptions.
Because of that, I deleted the line that adds the README, and modified the long description with the tentative text "Autoscripting Python for your presentations". Here, if the pull request is accepted, the author should define a proper Long Description for AutoPython.
After this change, and the 8 spaces instead of the tabs proposed earlier, lintian passess all the tests, which is absolutely good for the package to - someday - being accepted in Debian and Ubuntu. The output of lintian is ( after this fixes ) :
juan@beq:~/code/autopython-0.7-b1/deb_dist$ lintian python3-autopython_0.7-1_all.deb
W: python3-autopython: new-package-should-close-itp-bug
W: python3-autopython: binary-without-manpage usr/bin/autoipython3
W: python3-autopython: binary-without-manpage usr/bin/autopython3
Of course the first should be ignored, while number two and three are related to man pages that are not yet available.