Update GopherJS Playground to Go 1.8. #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go generate github.com/gopherjs/gopherjs.github.io/playground/internal/imports
Previous code would generate "$rootScope:inprog" AngularJS error (see https://docs.angularjs.org/error/$rootScope/inprog). I'm not fully sure what changed to cause that, but it seems this code can now be executed synchronously without a goroutine (i.e., it makes no blocking calls). According to AngularJS documentation (linked above), that is one possible cause of this error: > This error is often seen when interacting with an API that is sometimes sync and sometimes async. Perhaps something changed to cause formatting to no longer by asynchronous. Remove the goroutine and scope.Apply calls. It seems to work, but I'm not familiar with AngularJS enough to be confident this is the best thing to do. I'm also not sure what exactly changed to trigger the original error. Related to #64. Hopefully we can stop relying on AngularJS soon, and this potential problem can go away/wouldn't have happened.
Regenerated with GopherJS 1.8-1. go generate github.com/gopherjs/gopherjs.github.io/playground
neelance
approved these changes
Feb 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Go 1.8 (final) and GopherJS 1.8-1 (still on branch, gopherjs/gopherjs#552) to generate this.
Most of this PR is standard procedure and no different than for Go 1.6 (#42), 1.7 (f710646 and cd0bdc5), etc.
Except 723a993 which was weird. See commit message for details. (Also see relevant #64.)
Test plan, I used
goexec 'http.ListenAndServe(":8080", http.FileServer(http.Dir(".")))'to start an HTTP server serving contents of playground directory, then visited http://localhost:8080 in browser, hard-cleared all cache, and tested format button (both modes) and a small Go program. It worked without errors: