Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Chrome extension to Manifest V3 #261

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Migrate Chrome extension to Manifest V3 #261

merged 1 commit into from
Oct 12, 2024

Conversation

Pharb
Copy link
Member

@Pharb Pharb commented Oct 12, 2024

Notes:

  • "suggested_key" auto-conversion of "Ctrl" to "Command" on Mac does not work as documented by MDN / Chromium (I suspect this is a bug in Chromium, workaround is simple enough)
  • service worker does not follow current best practises regarding storage and timers (good enough for now, can be further improved)

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8e86e53) to head (e34cb50).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #261   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          738       740    +2     
  Branches       135       137    +2     
=========================================
+ Hits           738       740    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Pharb Pharb merged commit 18d4d59 into master Oct 12, 2024
14 checks passed
@Pharb Pharb deleted the chrome-manifest-v3 branch October 12, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant