[TEST] TrainSeatQueryService 테스트 #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimin730
approved these changes
Aug 7, 2025
Contributor
Jimin730
left a comment
Jimin730
left a comment
There was a problem hiding this comment.
예외 케이스까지 꼼꼼하게 작성해주셔서 복잡한 로직의 흐름을 확인하기 좋았던 것 같습니다 !
고생하셨습니다 👍 👍
Friox
approved these changes
Aug 7, 2025
Contributor
Friox
left a comment
Friox
left a comment
There was a problem hiding this comment.
케이스를 꼼꼼히 체크해서 커버리지 100%를 달성하셨네요,
고생하셨습니다! 👍👍
Ogu1208
approved these changes
Aug 7, 2025
Contributor
Ogu1208
left a comment
Ogu1208
left a comment
There was a problem hiding this comment.
꼼꼼한 테스트 코드를 보니 한결 마음이 편해지네요!
도와주셔서 감사합니다 ㅠㅠ 🥲 저도 예약쪽은 reservationService에 위임할 걸 그랬나 싶네요!
고생하셨습니다~ 👍👍
chanwonlee
force-pushed
the
test/220-train-seat-query
branch
from
a97ab62 to
b04061d
Compare
EndlessMilkyway
approved these changes
Aug 7, 2025
Contributor
EndlessMilkyway
left a comment
EndlessMilkyway
left a comment
There was a problem hiding this comment.
성공과 예외에 대한 모든 케이스를 꼼꼼하게 테스트해주셨군요! 고생많으셨습니다! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 Issue (필수)
주요 변경 사항 (필수)
리뷰어 참고 사항
추가 정보
없음
PR 작성 체크리스트 (필수)