[FEATURE] PendingBooking 다중 삭제 api 구현 #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanwonlee
approved these changes
Jan 6, 2026
Contributor
chanwonlee
left a comment
chanwonlee
left a comment
There was a problem hiding this comment.
예약 다중 삭제 API 코드 확인했습니다!
테스트 코드를 꼼꼼히 작성해 주셔서 코드 검증이 확실하게 되어 있네요!
고생하셨습니다! 👍👍
src/test/java/com/sudo/raillo/booking/application/PendingBookingServiceTest.java
Show resolved
Hide resolved
src/test/java/com/sudo/raillo/booking/application/PendingBookingServiceTest.java
Show resolved
Hide resolved
src/main/java/com/sudo/raillo/booking/application/service/PendingBookingService.java
Outdated
Show resolved
Hide resolved
Jimin730
force-pushed
the
feature/81-delete-pending-bookings
branch
from
c669206 to
41b0af9
Compare
Ogu1208
approved these changes
Jan 6, 2026
Contributor
Ogu1208
left a comment
Ogu1208
left a comment
There was a problem hiding this comment.
예약 삭제 로직 확인했습니다!
pendingBooking을 두가지 redis Key로 저장하고 있던것도 깜빡했는데 꼼꼼하게 작업해주신 덕에 다시 상기시켰네요 😅
존재하지 않는 임시 예약 ID로 삭제해도 예외가 발생하지 않도록 설계하신 점도 좋은 것 같습니다!
고생하셨습니다~ 👍
src/main/java/com/sudo/raillo/booking/application/service/PendingBookingService.java
Show resolved
Hide resolved
src/test/java/com/sudo/raillo/booking/application/PendingBookingServiceTest.java
Show resolved
Hide resolved
Jimin730
force-pushed
the
feature/81-delete-pending-bookings
branch
from
91dcd3f to
9edcc4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 Issue (필수)
주요 변경 사항 (필수)
리뷰어 참고 사항
없음
추가 정보
없음
PR 작성 체크리스트 (필수)