Skip to content

Conversation

@MaxLee-dev
Copy link
Contributor

@MaxLee-dev MaxLee-dev commented Oct 27, 2025

Description of Changes

Improve the concurrency grouping in the quality workflow by using github.head_ref || github.ref instead of just github.ref. This ensures that:

  • For pull requests, workflows are grouped by PR branch name (head_ref)
  • For direct branch pushes, workflows fall back to the ref

This prevents multiple workflow runs from different commits in the same PR from running simultaneously, improving CI efficiency.

Checklist

  • The PR title follows the Conventional Commits convention. (e.g., feat, fix, docs, style, refactor, test, chore)
  • I have performed a self-code review.
  • I have followed the project's coding conventions and component patterns.

Use head_ref for PR-based workflows to ensure proper concurrency cancellation per PR branch instead of per commit ref.
@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2025

⚠️ No Changeset found

Latest commit: d91456a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@vercel
Copy link

vercel bot commented Oct 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
vapor-ui Ready Ready Preview Comment Oct 28, 2025 0:04am

@vapor-ui
Copy link
Collaborator

All tests passed!

Tests Passed Failed Duration Report
120 120 0 1m 20s Open report ↗︎

Click here if you need to update snapshots.

@MaxLee-dev MaxLee-dev self-assigned this Oct 27, 2025
@MaxLee-dev MaxLee-dev force-pushed the quality-workflow-concurrency branch from e98c242 to b2bf3eb Compare October 27, 2025 23:44
Comment on lines +23 to +25
concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.ref }}
cancel-in-progress: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to quality checks, when a new commit is pushed to packages/core, previous tests become obsolete, so concurrency is added.

@MaxLee-dev MaxLee-dev marked this pull request as draft October 31, 2025 03:46
@MaxLee-dev MaxLee-dev marked this pull request as ready for review November 28, 2025 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants