-
Notifications
You must be signed in to change notification settings - Fork 10
chore: integrate .prettierignore files into root #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello @MaxLee-dev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the project's Prettier configuration by centralizing all ignore rules into a single file at the repository root. This change simplifies maintenance and ensures consistent formatting exclusion across all packages and applications within the monorepo structure. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
이 PR은 여러 패키지에 분산되어 있던 .prettierignore 파일을 루트의 단일 파일로 통합하여 설정 관리를 간소화합니다. 변경 사항은 올바르며, 코드베이스의 유지보수성을 향상시키는 좋은 단계입니다. 추가적으로, 향후 다른 패키지에서도 일관되게 적용될 수 있도록 몇 가지 일반적인 예외 패턴을 추가하고 정렬하여 가독성을 높이는 것을 제안했습니다.
.prettierignore
Outdated
| dist | ||
| .turbo | ||
| node_modules | ||
| public | ||
| public |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description of Changes
Consolidated all
.prettierignorefiles from individual packages into a single root-level.prettierignorefile to simplify configuration management.prettier support only for top level prettierignore
Changes:
.prettierignorewith combined patterns:dist,.turbo,node_modules,public.prettierignorefiles from:packages/color-generator/packages/css-generator/apps/figma-plugin/Checklist