Skip to content

fix: resolve podspec conflict & set xcode version @build_test_cocoapod stage & update README with EEA terms links #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 12, 2025

Conversation

iHackSubhodip
Copy link
Collaborator

@iHackSubhodip iHackSubhodip commented Jul 9, 2025

What's changing?

  • Adds links to Google Maps Platform European Economic Area (EEA) terms of service effective 8th July 2025.
  • Resolve podspec conflict
  • Set xcode version @build_test_cocoapod stage

Fixes #553 🦕

@iHackSubhodip iHackSubhodip changed the title Update README with EEA terms links chore: Update README with EEA terms links Jul 9, 2025
@iHackSubhodip iHackSubhodip changed the title chore: Update README with EEA terms links chore: Update README with EEA terms links & resolve podspec conflict Jul 24, 2025
@iHackSubhodip iHackSubhodip changed the title chore: Update README with EEA terms links & resolve podspec conflict chore: Update README with EEA terms links Jul 24, 2025
@iHackSubhodip iHackSubhodip changed the title chore: Update README with EEA terms links chore: Update README with EEA terms links, resolve podspec conflict & set xcode version @build_test_cocoapod stage Jul 24, 2025
Copy link
Member

@wangela wangela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the highest level of the commits involved in this RP is fix, the prefix should be fix: and we will expect to generate a new patch release version with this change.

@iHackSubhodip iHackSubhodip changed the title chore: Update README with EEA terms links, resolve podspec conflict & set xcode version @build_test_cocoapod stage fix: resolve podspec conflict & set xcode version @build_test_cocoapod stage & update README with EEA terms links Jul 24, 2025
@iHackSubhodip iHackSubhodip requested a review from wangela July 24, 2025 16:32
Copy link
Member

@wangela wangela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but @boilerwadding should approve since I'm not involved in the EEA wording requirements so I don't know what we're required to add to the README. It doesn't seem like the sentence about Map Tiles API applies to this library.

Copy link

@boilerwadding boilerwadding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The EEA Terms text in README.md should not include the sentence about Map Tiles API.

It only needs to have the following:

European Economic Area (EEA) developers

If your billing address is in the European Economic Area, effective on 8 July 2025, the Google Maps Platform EEA Terms of Service will apply to your use of the Services. Learn more.

@iHackSubhodip iHackSubhodip merged commit ff42018 into main Aug 12, 2025
12 checks passed
@iHackSubhodip iHackSubhodip deleted the SB/update-readme-eea branch August 12, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update README with EEA terms links
3 participants