-
Notifications
You must be signed in to change notification settings - Fork 424
fix: resolve podspec conflict & set xcode version @build_test_cocoapod stage & update README with EEA terms links #554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…aps-iOS-Utils.podspec`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the highest level of the commits involved in this RP is fix
, the prefix should be fix:
and we will expect to generate a new patch release version with this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but @boilerwadding should approve since I'm not involved in the EEA wording requirements so I don't know what we're required to add to the README. It doesn't seem like the sentence about Map Tiles API applies to this library.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The EEA Terms text in README.md should not include the sentence about Map Tiles API.
It only needs to have the following:
European Economic Area (EEA) developers
If your billing address is in the European Economic Area, effective on 8 July 2025, the Google Maps Platform EEA Terms of Service will apply to your use of the Services. Learn more.
What's changing?
Fixes #553 🦕