fix: flutter plugin lifecycle logic #487
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jokerttu
force-pushed
the
fix/flutter-plugin-lifecycle-logic
branch
from
dcb75e1 to
f0e0092
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with the Flutter plugin lifecycle handling.
The problem was that
GoogleMapsNavigationSessionManagerwas being created in theonAttachedToActivitylifecycle method instead ofonAttachedToEngine. As a result, the required method channels were not initialized in time. This issue became visible when a cached Flutter engine was used. Also improved state handling for the plugin.Fixes #238
Pre-launch Checklist