Skip to content

chore: improve tests by adding realtime delays #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: improve tests by adding realtime delays #477

wants to merge 1 commit into from

Conversation

jokerttu
Copy link
Contributor

This change improves test reliability by adding real-time delays instead of relying on tester.pump, which only advances the framework’s internal clock without waiting for actual native events to complete.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation
  • I added new tests to check the change I am making
  • All existing and new tests are passing.

@jokerttu jokerttu requested a review from caio1985 September 12, 2025 12:50
@jokerttu
Copy link
Contributor Author

@caio1985 this can be merged after reviewed

caio1985
caio1985 approved these changes Oct 1, 2025
View reviewed changes
Copy link
Collaborator

@caio1985 caio1985 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caio1985 caio1985 caio1985 approved these changes

Assignees

@caio1985 caio1985

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jokerttu @caio1985