Begin config migration #1123
Merged
Begin config migration #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't compile so makes workspace level changes annoying to check
This isn't used anywhere
Jake-Shadle
force-pushed
the
specialized-cfg
branch
from
8d291d6 to
3a05306
Compare
|
Build Succeeded 🥳 Build Id: 8786dff1-433f-435a-835b-cf14196842ee The following development images have been built, and will exist for the next 30 days: To build this version: |
XAMPPRocky
reviewed
Feb 20, 2025
| } | ||
|
|
||
| #[cfg(test)] | ||
| impl<'de> Deserialize<'de> for Config { |
There was a problem hiding this comment.
Any reason for the manual impl over a derive?
There was a problem hiding this comment.
Because the dynamic config will require manual deserialization so just getting it out of the way now.
Comment on lines
+741
to
+745
| dyn_cfg: DynamicConfig { | ||
| id: default_id(), | ||
| version: Version::default(), | ||
| typemap: default_typemap(), | ||
| }, |
There was a problem hiding this comment.
Is there a reason DynamicConfig doesn't impl default?
There was a problem hiding this comment.
Not really, will probably add it eventually.
XAMPPRocky
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DynamicConfigas a field ofConfigidandversiontoDynamicConfig<C: Serialize>as it only cares about dumping the config as JSONPart of #1117