Defer shutdown until actives sessions are 0 #1108
Open
+172
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is already handled in config.toml, and only adds the flags for the x86 arch so that warnings aren't emitted
XAMPPRocky
reviewed
Feb 10, 2025
|
/gcbrun |
|
Build Succeeded 🥳 Build Id: 9861171b-3e5c-4d73-85f5-012784bd248e The following development images have been built, and will exist for the next 30 days: To build this version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defers shutdown by still processing I/O requests in the existing downstream and session handlers, but blocks downstream loops from creating new sessions, so sessions will stay alive as long as traffic continues, but once they don't have traffic any longer they will eventually be pruned from the pool, and shutdown will continue, also shutting down the phoenix thread if it exists before informing the proxy to exit.
Resolves: #1107