Skill Based Example using Default Evaluator #1252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Updated comments for sample. Will add more robust code to sample
|
This method is up for discussion: cloning the tutorial folder vs. updated docs + code samples only. Looking for suggestions. |
|
Quick question - should this have unit tests? (In open match, do you run example unit tests with your regular CI stuff? I'm not sure, but thought I'd throw this out there as a suggestion). More unit testing gooder anyway. |
…ed mmf specific files and folders to folder in samples directory.
…faultevalskill Pull from upstream
…tencytemplate Merge changes from master to new branch latencytemplate
…s will hold skeleton code for various matchfunction scenarios such as latency, skill, game modes. This commit has a sample evaluation logic that may not be suitable for skeleton code but rather a README so changes may be made
…faultevalskill Merge from master
|
Moved to Open Match Ecosystem googleforgames/open-match-ecosystem#11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it:
This PR is an example for skill based match functions. Staying true to our documentation on evaluators, this sample uses the default evaluator along with a function to access match score/quality as shown in our current default evaluator tutorial. This was needed based on questions/feedback from Slack discussions.
The sample is a clone of the Default Evaluator tutorial folder with updates for skill based matchmaking vs. the mode based + queue entry time currently shown. Match score function returns the difference between highest and lowest skill ratings (the lower the difference, the better match will be).
Which issue(s) this PR fixes:
Works on #1200
Special notes for your reviewer:
This will be a two part sample. One for default evaluator and another for custom evaluator which will come later.