Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds helm schema validation test to the test suite #4101

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Feb 5, 2025

What type of PR is this?

/kind feature

What this PR does / Why we need it:

Final piece in the in-place upgrades moving to beta.

Adds a simple Helm schema validation test that runs as part of make test in CI / CD.

Note that this test only tests that the Helm values.yaml file passes the schema validation. It does not test if there have been changes to the Helm template that require changes to the validation schema.

Which issue(s) this PR fixes:

Closes #4093
Closes #3766

Special notes for your reviewer:

@github-actions github-actions bot added kind/feature New features for Agones size/XS labels Feb 5, 2025
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: f8cf0c1a-e551-432f-8852-ae4a8ea6808b

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: cc5060bc-7fca-45bc-ab4a-1a0b1ef3192a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4101/head:pr_4101 && git checkout pr_4101
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.47.0-dev-d9ef8ca

@igooch igooch requested a review from peterzhongyi February 5, 2025 22:44
@lacroixthomas
Copy link
Collaborator

Can't approve, but LGTM, also tested locally

@peterzhongyi peterzhongyi merged commit d62bf66 into googleforgames:main Feb 6, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New features for Agones size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON Schema Validation for Helm RFC: In-place Agones Upgrades
4 participants