Skip to content

fix: bump version of jsonpatch for lossy max int64 #4090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lacroixthomas
Copy link
Collaborator

What type of PR is this?

/kind bug

What this PR does / Why we need it:
This PR bump the version of the jsonpath module, which includes a fix for the lossy int64 max values

Currently, the jsonpath transform the int64 (big values, max int64 for example) as a float64 with scientific notation, when cast back to a int64, it losses precision / the int64 is not the same.

Which issue(s) this PR fixes:
Closes #3636

Special notes for your reviewer:
A PR has been opened on the jsonpath repo: gomodules/jsonpatch#40

The repo doesn't seems to be maintained, I open this draft PR to do some test by using by fork

@github-actions github-actions bot added kind/bug These are bugs. size/S labels Jan 20, 2025
@0xaravindh
Copy link
Member

/gcbrun

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: e5880dfc-cb0f-4c28-bc09-117782483f3a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4090/head:pr_4090 && git checkout pr_4090
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.47.0-dev-8ec1ed7

@lacroixthomas
Copy link
Collaborator Author

Did some manual, testing, it seems to be working well
Awaiting approval from the other repo: gomodules/jsonpatch#40
Will then update the go mod

@markmandel
Copy link
Collaborator

https://github.com/gomodules/jsonpatch/releases/tag/v2.5.0 contains this fix, so now we can update this PR to point to that release.

@lacroixthomas lacroixthomas force-pushed the bugfixes/fix-lossy-max-int64 branch from c5fb555 to 91f7b74 Compare March 10, 2025 13:03
@lacroixthomas lacroixthomas marked this pull request as ready for review March 10, 2025 13:03
@lacroixthomas lacroixthomas force-pushed the bugfixes/fix-lossy-max-int64 branch from 1b66b83 to 91f7b74 Compare March 10, 2025 13:31
@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: c3940116-8cea-4810-b3ab-f7ad33dc71c3

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4090/head:pr_4090 && git checkout pr_4090
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.48.0-dev-91f7b74

Copy link
Collaborator

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@markmandel markmandel merged commit 5703808 into googleforgames:main Mar 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug These are bugs. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON Patch in GameServer Controller is Lossy on Int64
4 participants