-
Notifications
You must be signed in to change notification settings - Fork 857
fix: bump version of jsonpatch for lossy max int64 #4090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump version of jsonpatch for lossy max int64 #4090
Conversation
/gcbrun |
Build Succeeded 🥳 Build Id: e5880dfc-cb0f-4c28-bc09-117782483f3a The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Did some manual, testing, it seems to be working well |
https://github.com/gomodules/jsonpatch/releases/tag/v2.5.0 contains this fix, so now we can update this PR to point to that release. |
c5fb555
to
91f7b74
Compare
1b66b83
to
91f7b74
Compare
Build Succeeded 🥳 Build Id: c3940116-8cea-4810-b3ab-f7ad33dc71c3 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
What type of PR is this?
/kind bug
What this PR does / Why we need it:
This PR bump the version of the jsonpath module, which includes a fix for the lossy int64 max values
Currently, the jsonpath transform the int64 (big values, max int64 for example) as a float64 with scientific notation, when cast back to a int64, it losses precision / the int64 is not the same.
Which issue(s) this PR fixes:
Closes #3636
Special notes for your reviewer:
A PR has been opened on the jsonpath repo: gomodules/jsonpatch#40
The repo doesn't seems to be maintained, I open this draft PR to do some test by using by fork