Merge branch 'main' into refactor-to-subsystem

.github/ISSUE_TEMPLATE/kubernetes_update.md

@@ -21,6 +21,9 @@ List of items to do for upgrading to {version_1} {version_2} {version_3}
         {version_3}
   - [ ] Update Kubernetes version of EKS to the newest supported version in {version_1} {version_2}
         {version_3}
+- [ ] Update the OKE example cluster version of terraform submodules to the newest supported version in {version_1} {version_2} {version_3}. Note the version should include the patch version.
+  - [ ] Update Kubernetes version in examples/terraform-submodules/oke/variables.tf 
+  - [ ] Update Kubernetes version in examples/terraform-submodules/oke/terraform.auto.tfvars.example 
 - [ ] Update kubectl in dev tooling to {version_2}, the latest patch version can be found
       [here](https://kubernetes.io/releases/)
   - [ ] Update kubectl in `build/build-image/Dockerfile`

.golangci.yml

@@ -18,14 +18,6 @@ run:
   # list of build tags, all linters use it. Default is empty list.
   build-tags:
 
-  # which dirs to skip: they won't be analyzed;
-  # can use regexp here: generated.*, regexp is applied on full path;
-  # default value is empty list, but next dirs are always skipped independently
-  # from this option's value:
-  #   	vendor$, third_party$, testdata$, examples$, Godeps$, builtin$
-  skip-dirs:
-    - test/sdk/restapi
-
   # which files to skip: they will be analyzed, but issues from them
   # won't be reported. Default value is empty list, but there is
   # no need to include all autogenerated files, we confidently recognize
@@ -34,8 +26,15 @@ run:
   modules-download-mode: vendor
 # output configuration options
 output:
-  # colored-line-number|line-number|json|tab|checkstyle, default is "colored-line-number"
-  format: colored-line-number
+  # the formats used to render issues
+  # formats: colored-line-number, line-number, json, colored-tab,
+  #          tab, html, checkstyle, code-climate, junit-xml,
+  #          junit-xml-extended, github-actions, teamcity, sarif
+  # output path can be either `stdout`, `stderr`
+  # or path to the file to write to
+  formats:
+    - format: colored-line-number
+      path: stdout
 
   # print lines of code with issue, default is true
   print-issued-lines: true
@@ -45,20 +44,21 @@ output:
 linters:
   enable:
     - bodyclose
+    - copyloopvar
     - dupl
-    - exportloopref
     - goconst
     - gocritic
     - gocyclo
     - goimports
+    - gosimple
     - govet
-    - megacheck
     - misspell
     - nakedret
     - revive
     - staticcheck
     - unconvert
     - unparam
+    - unused
 linters-settings:
   govet:
     disable-all: false
@@ -88,3 +88,10 @@ issues:
     - path: (.+)_test\.go|^test/|^cmd/.*|^pkg/apis/.*
       # fieldalignment is in the `govet` linter, so exclude based on text instead of all of govet
       text: '^fieldalignment: .*'
+
+  # which dirs to exclude: issues from them won't be reported
+  # default dirs are skipped independently of this option's value
+  # (see exclude-dirs-use-default)
+  # default: []
+  exclude-dirs:
+    - test/sdk/restapi

CHANGELOG.md

@@ -1,5 +1,43 @@
 # Changelog
 
+## [v1.46.0](https://github.com/googleforgames/agones/tree/v1.46.0) (2025-01-02)
+
+[Full Changelog](https://github.com/googleforgames/agones/compare/v1.45.0...v1.46.0)
+
+**Breaking changes:**
+- Removed reflector metric usage by @vicentefb in https://github.com/googleforgames/agones/pull/4056
+
+**Implemented enhancements:**
+- Set externalTrafficPolicy as Local for agones-allocator by @osterante in https://github.com/googleforgames/agones/pull/4022
+- Integrates upgrades tests into Cloud Build by @igooch in https://github.com/googleforgames/agones/pull/4037
+- Delete List Value(s) on Game Server Allocation by @igooch in https://github.com/googleforgames/agones/pull/4054
+- In place upgrades version update instructions by @igooch in https://github.com/googleforgames/agones/pull/4064
+
+**Fixed bugs:**
+- Correct CI check for examples and add a unit test by @wheatear-dev in https://github.com/googleforgames/agones/pull/4045
+- Enable counter based autoscaler to scale from 0 replicas by @geopaulm in https://github.com/googleforgames/agones/pull/4049
+
+**Other:**
+- Preparation for Release v1.46.0 by @0xaravindh in https://github.com/googleforgames/agones/pull/4043
+- Updates Kubernetes templates for cpp-simple image by @0xaravindh in https://github.com/googleforgames/agones/pull/4044
+- Changes upgrades clusters to use only us based regions by @igooch in https://github.com/googleforgames/agones/pull/4046
+- Clarify docs on GKE Autopilot and node pools by @danfairs in https://github.com/googleforgames/agones/pull/4048
+- Updated typo's in multiple files by @nallave in https://github.com/googleforgames/agones/pull/4055
+- Flake: e2e/TestScheduleAutoscaler by @markmandel in https://github.com/googleforgames/agones/pull/4058
+- Add ability to specify additional labels for controller and extension pods by @R4oulDuk3 in https://github.com/googleforgames/agones/pull/4057
+- Adds Documention for how to run an in-place Agones upgrade by @igooch in https://github.com/googleforgames/agones/pull/3904
+- Fixes build error in push-upgrade-test by @igooch in https://github.com/googleforgames/agones/pull/4065
+- Fix broken link by @0xaravindh in https://github.com/googleforgames/agones/pull/4070
+- Link to Google Cloud Agones Support. by @markmandel in https://github.com/googleforgames/agones/pull/4071
+- Upgrade Go to 1.23.4 and update example image tags by @0xaravindh in https://github.com/googleforgames/agones/pull/4072
+- Unblocks Agones release PR by waiting for either the Agones dev version or release version by @igooch in https://github.com/googleforgames/agones/pull/4078
+
+**New Contributors:**
+- @danfairs made their first contribution in https://github.com/googleforgames/agones/pull/4048
+- @osterante made their first contribution in https://github.com/googleforgames/agones/pull/4022
+- @nallave made their first contribution in https://github.com/googleforgames/agones/pull/4055
+- @R4oulDuk3 made their first contribution in https://github.com/googleforgames/agones/pull/4057
+
 ## [v1.45.0](https://github.com/googleforgames/agones/tree/v1.45.0) (2024-11-19)
 
 [Full Changelog](https://github.com/googleforgames/agones/compare/v1.44.0...v1.45.0)

build/Makefile

@@ -24,7 +24,7 @@
 #
 
 # base version target. This is usually the next release.
-base_version = 1.46.0
+base_version = 1.47.0
 
 #
 # All of the following can be overwritten with environment variables
@@ -64,7 +64,7 @@ KIND_PROFILE ?= agones
 KIND_CONTAINER_NAME=$(KIND_PROFILE)-control-plane
 
 # Game Server image to use while doing end-to-end tests
-GS_TEST_IMAGE ?= us-docker.pkg.dev/agones-images/examples/simple-game-server:0.35
+GS_TEST_IMAGE ?= us-docker.pkg.dev/agones-images/examples/simple-game-server:0.36
 
 # Enable all beta feature gates. Keep in sync with `true` (beta) entries in pkg/util/runtime/features.go:featureDefaults
 BETA_FEATURE_GATES ?= "AutopilotPassthroughPort=true&CountsAndLists=true&DisableResyncOnSDKServer=true&GKEAutopilotExtendedDurationPods=true"

build/agones-bot/Dockerfile

@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-FROM golang:1.22 AS build-env
+FROM golang:1.23 AS build-env
 COPY . /go-src
 WORKDIR /go-src
 RUN CGO_ENABLED=0 go build -o /go-app .

build/agones-bot/go.mod

@@ -14,7 +14,7 @@
 
 module github-bot
 
-go 1.22
+go 1.23
 
 require (
 	github.com/GoogleCloudPlatform/cloud-build-notifiers/lib/notifiers v0.0.0-20210219212036-163c92a64b27
@@ -61,12 +61,12 @@ require (
 	go.opentelemetry.io/otel v1.21.0 // indirect
 	go.opentelemetry.io/otel/metric v1.21.0 // indirect
 	go.opentelemetry.io/otel/trace v1.21.0 // indirect
-	golang.org/x/crypto v0.21.0 // indirect
+	golang.org/x/crypto v0.31.0 // indirect
 	golang.org/x/exp v0.0.0-20240103183307-be819d1f06fc // indirect
 	golang.org/x/net v0.23.0 // indirect
-	golang.org/x/sync v0.6.0 // indirect
-	golang.org/x/sys v0.18.0 // indirect
-	golang.org/x/text v0.14.0 // indirect
+	golang.org/x/sync v0.10.0 // indirect
+	golang.org/x/sys v0.28.0 // indirect
+	golang.org/x/text v0.21.0 // indirect
 	golang.org/x/time v0.5.0 // indirect
 	google.golang.org/api v0.155.0 // indirect
 	google.golang.org/appengine v1.6.8 // indirect

build/agones-bot/go.sum

@@ -259,8 +259,8 @@ golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550/go.mod h1:yigFU9vqHzYiE8U
 golang.org/x/crypto v0.0.0-20200622213623-75b288015ac9/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto=
 golang.org/x/crypto v0.0.0-20210921155107-089bfa567519/go.mod h1:GvvjBRRGRdwPK5ydBHafDWAxML/pGHZbMvKqRZ5+Abc=
 golang.org/x/crypto v0.3.0/go.mod h1:hebNnKkNXi2UzZN1eVRvBB7co0a+JxK6XbPiWVs/3J4=
-golang.org/x/crypto v0.21.0 h1:X31++rzVUdKhX5sWmSOFZxx8UW/ldWx55cbf08iNAMA=
-golang.org/x/crypto v0.21.0/go.mod h1:0BP7YvVV9gBbVKyeTG0Gyn+gZm94bibOW5BjDEYAOMs=
+golang.org/x/crypto v0.31.0 h1:ihbySMvVjLAeSH1IbfcRTkD/iNscyz8rGzjF/E5hV6U=
+golang.org/x/crypto v0.31.0/go.mod h1:kDsLvtWBEx7MV9tJOj9bnXsPbxwJQ6csT/x4KIN4Ssk=
 golang.org/x/exp v0.0.0-20190121172915-509febef88a4/go.mod h1:CJ0aWSM057203Lf6IL+f9T1iT9GByDxfZKAQTCR3kQA=
 golang.org/x/exp v0.0.0-20190306152737-a1d7652674e8/go.mod h1:CJ0aWSM057203Lf6IL+f9T1iT9GByDxfZKAQTCR3kQA=
 golang.org/x/exp v0.0.0-20190510132918-efd6b22b2522/go.mod h1:ZjyILWgesfNpC6sMxTJOJm9Kp84zZh5NQWvqDGG3Qr8=
@@ -357,8 +357,8 @@ golang.org/x/sync v0.0.0-20200625203802-6e8e738ad208/go.mod h1:RxMgew5VJxzue5/jJ
 golang.org/x/sync v0.0.0-20201020160332-67f06af15bc9/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
 golang.org/x/sync v0.0.0-20201207232520-09787c993a3a/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
 golang.org/x/sync v0.0.0-20220722155255-886fb9371eb4/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
-golang.org/x/sync v0.6.0 h1:5BMeUDZ7vkXGfEr1x9B4bRcTH4lpkTkpdh0T/J+qjbQ=
-golang.org/x/sync v0.6.0/go.mod h1:Czt+wKu1gCyEFDUtn0jG5QVvpJ6rzVqr5aXyt9drQfk=
+golang.org/x/sync v0.10.0 h1:3NQrjDixjgGwUOCaF8w2+VYHv0Ve/vGYSbdkTa98gmQ=
+golang.org/x/sync v0.10.0/go.mod h1:Czt+wKu1gCyEFDUtn0jG5QVvpJ6rzVqr5aXyt9drQfk=
 golang.org/x/sys v0.0.0-20180830151530-49385e6e1522/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
 golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
 golang.org/x/sys v0.0.0-20190312061237-fead79001313/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
@@ -395,8 +395,8 @@ golang.org/x/sys v0.0.0-20210615035016-665e8c7367d1/go.mod h1:oPkhp1MJrh7nUepCBc
 golang.org/x/sys v0.0.0-20220520151302-bc2c85ada10a/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.0.0-20220722155257-8c9f86f7a55f/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.2.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
-golang.org/x/sys v0.18.0 h1:DBdB3niSjOA/O0blCZBqDefyWNYveAYMNF1Wum0DYQ4=
-golang.org/x/sys v0.18.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
+golang.org/x/sys v0.28.0 h1:Fksou7UEQUWlKvIdsqzJmUmCX3cZuD2+P3XyyzwMhlA=
+golang.org/x/sys v0.28.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
 golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo=
 golang.org/x/term v0.0.0-20210927222741-03fcf44c2211/go.mod h1:jbD1KX2456YbFQfuXm/mYQcufACuNUgVhRMnK/tPxf8=
 golang.org/x/term v0.2.0/go.mod h1:TVmDHMZPmdnySmBfhjOoOdhjzdE1h4u1VwSiw2l1Nuc=
@@ -410,8 +410,8 @@ golang.org/x/text v0.3.5/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
 golang.org/x/text v0.3.7/go.mod h1:u+2+/6zg+i71rQMx5EYifcz6MCKuco9NR6JIITiCfzQ=
 golang.org/x/text v0.3.8/go.mod h1:E6s5w1FMmriuDzIBO73fBruAKo1PCIq6d2Q6DHfQ8WQ=
 golang.org/x/text v0.4.0/go.mod h1:mrYo+phRRbMaCq/xk9113O4dZlRixOauAjOtrjsXDZ8=
-golang.org/x/text v0.14.0 h1:ScX5w1eTa3QqT8oi6+ziP7dTV1S2+ALU0bI+0zXKWiQ=
-golang.org/x/text v0.14.0/go.mod h1:18ZOQIKpY8NJVqYksKHtTdi31H5itFRjB5/qKTNYzSU=
+golang.org/x/text v0.21.0 h1:zyQAAkrwaneQ066sspRyJaG9VNi/YJ1NfzcGB3hZ/qo=
+golang.org/x/text v0.21.0/go.mod h1:4IBbMaMmOPCJ8SecivzSH54+73PCFmPWxNTLm+vZkEQ=
 golang.org/x/time v0.0.0-20181108054448-85acf8d2951c/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
 golang.org/x/time v0.0.0-20190308202827-9d24e82272b4/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
 golang.org/x/time v0.0.0-20191024005414-555d28b269f0/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=

build/build-image/Dockerfile

@@ -28,7 +28,7 @@ RUN gem install fpm && \
 
 # install go
 WORKDIR /usr/local
-ENV GO_VERSION=1.22.6
+ENV GO_VERSION=1.23.4
 ENV GOPATH /go
 ENV GO111MODULE=on
 RUN wget -q https://dl.google.com/go/go${GO_VERSION}.linux-amd64.tar.gz && \

build/build-sdk-images/go/Dockerfile

@@ -20,7 +20,7 @@ RUN apt-get --allow-releaseinfo-change update && \
 
 # install go
 WORKDIR /usr/local
-ENV GO_VERSION=1.22.6
+ENV GO_VERSION=1.23.4
 ENV GO111MODULE=on
 ENV GOPATH /go
 RUN wget -q https://dl.google.com/go/go${GO_VERSION}.linux-amd64.tar.gz && \

build/build-sdk-images/restapi/Dockerfile

@@ -20,7 +20,7 @@ RUN apt-get --allow-releaseinfo-change update && \
 
 # install go
 WORKDIR /usr/local
-ENV GO_VERSION=1.22.6
+ENV GO_VERSION=1.23.4
 ENV GO111MODULE=on
 ENV GOPATH /go
 RUN wget -q https://dl.google.com/go/go${GO_VERSION}.linux-amd64.tar.gz && \

build/e2e-image/Dockerfile

@@ -6,7 +6,7 @@ RUN apt-get update && \
 
 # install go
 WORKDIR /usr/local
-ENV GO_VERSION=1.22.6
+ENV GO_VERSION=1.23.4
 ENV GOPATH /go
 ENV GO111MODULE=on
 RUN wget -q https://dl.google.com/go/go${GO_VERSION}.linux-amd64.tar.gz && \