Skip to content

fix: manage graalvm image versions via Hermetic Build templates _only_ #3800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025

Conversation

diegomarquezp
Copy link
Contributor

So far these versions are managed both by renovate-bot and Hermetic Build. Since each release of Hermetic Build keeps these template versions up to date, it's better suited to manage these versions via Hermetic Build.

The updates should be reflected by updating .github/workflows/hermetic_library_generation.yaml referenced version to the current released one.

So far these versions are managed both by renovate-bot and Hermetic Build. Since each release of Hermetic Build keeps these template versions up to date, it's better suited to manage these versions via Hermetic Build.

The updates should be reflected by updating `.github/workflows/hermetic_library_generation.yaml` referenced version to the current released one.
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label May 16, 2025
@diegomarquezp
Copy link
Contributor Author

Showcase failure seems unrelated:

[INFO] Compiling 7 proto file(s) to /home/runner/work/sdk-platform-java/sdk-platform-java/gapic-generator-java/target/generated-test-sources/protobuf/java
Error:  PROTOC FAILED: google/logging/v2/logging_config.proto:22:1: warning: Import google/protobuf/duration.proto is unused.
logging.proto:227:12: "LogEntry" is not defined.
logging.proto:315:12: "LogEntry" is not defined.
logging.proto:470:12: "LogEntry" is not defined.

Error:  /home/runner/work/sdk-platform-java/sdk-platform-java/gapic-generator-java/target/generated-test-sources/proto/logging.proto [0:0]: google/logging/v2/logging_config.proto:22:1: warning: Import google/protobuf/duration.proto is unused.
logging.proto:227:12: "LogEntry" is not defined.
logging.proto:315:12: "LogEntry" is not defined.
logging.proto:470:12: "LogEntry" is not defined.

Copy link
Collaborator

@blakeli0 blakeli0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If renovate.json has been updated manually, is this change going to merge with the manual changes? If not, I think we still need to follow up with each handwritten library to change their renovate.json?

@diegomarquezp
Copy link
Contributor Author

diegomarquezp commented May 20, 2025

If renovate.json has been updated manually, is this change going to merge with the manual changes? If not, I think we still need to follow up with each handwritten library to change their renovate.json?

@blakeli0 this file does not have merge logic in hermetic build. We will need manual changes in each repo.

I'll take care of the manual ones.

Copy link

Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@diegomarquezp diegomarquezp merged commit 244c5dc into main May 22, 2025
107 of 113 checks passed
@diegomarquezp diegomarquezp deleted the diegomarquezp-patch-2 branch May 22, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants