-
Notifications
You must be signed in to change notification settings - Fork 66
fix: manage graalvm image versions via Hermetic Build templates _only_ #3800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
So far these versions are managed both by renovate-bot and Hermetic Build. Since each release of Hermetic Build keeps these template versions up to date, it's better suited to manage these versions via Hermetic Build. The updates should be reflected by updating `.github/workflows/hermetic_library_generation.yaml` referenced version to the current released one.
Showcase failure seems unrelated:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If renovate.json
has been updated manually, is this change going to merge with the manual changes? If not, I think we still need to follow up with each handwritten library to change their renovate.json
?
@blakeli0 this file does not have merge logic in hermetic build. We will need manual changes in each repo. I'll take care of the manual ones. |
|
|
So far these versions are managed both by renovate-bot and Hermetic Build. Since each release of Hermetic Build keeps these template versions up to date, it's better suited to manage these versions via Hermetic Build.
The updates should be reflected by updating
.github/workflows/hermetic_library_generation.yaml
referenced version to the current released one.