Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: add opentelemetry gcp-resources to shared deps #3722

Merged
merged 4 commits into from
Apr 2, 2025
Merged

deps: add opentelemetry gcp-resources to shared deps #3722

merged 4 commits into from
Apr 2, 2025

Conversation

JesseLovelace
Copy link
Contributor

b/406556155

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Mar 26, 2025
@JesseLovelace JesseLovelace added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 26, 2025
@JesseLovelace JesseLovelace marked this pull request as draft March 26, 2025 20:48
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Apr 1, 2025
@JesseLovelace JesseLovelace removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 1, 2025
@JesseLovelace JesseLovelace marked this pull request as ready for review April 1, 2025 18:57
@JesseLovelace JesseLovelace changed the title deps: add opentelemetry detector-resources, opentelemetry-resources, … deps: add opentelemetry gcp-resources to shared deps Apr 1, 2025
zhumin8
zhumin8 approved these changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@zhumin8 zhumin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failed "library-generation-integration-test" is irrelevant to this change.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 2, 2025

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 2, 2025

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@zhumin8 zhumin8 merged commit b1b075d into main Apr 2, 2025
56 of 57 checks passed
@zhumin8 zhumin8 deleted the addmoreoteldeps branch April 2, 2025 20:50
@release-please release-please bot mentioned this pull request Apr 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhumin8 zhumin8 zhumin8 approved these changes

Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JesseLovelace @zhumin8