-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable MTLS_S2A bound token by default for gRPC S2A enabled flows #3591
Merged
+136
−3
Merged
Changes from 3 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
a091561
Request MTLS_S2A hard bound tokens.
rmehta19 152ed13
Merge branch 'main' into mtls-s2a-hard-binding
rmehta19 39fa157
add some tests.
rmehta19 7c20422
address latest comments.
rmehta19 3864db8
Merge branch 'main' into mtls-s2a-hard-binding
rmehta19 d8b2959
address more comments.
rmehta19 3c8da4e
remove nullable tag in builder.
rmehta19 8c060dc
add comments, change checkNotNull message, add ALTS to test.
rmehta19 c8528b8
Merge branch 'main' into mtls-s2a-hard-binding
rmehta19 2c41813
move credential creation out of createSingleChannel.
rmehta19 c487491
Merge branch 'main' into mtls-s2a-hard-binding
rmehta19 0fe5134
init allowedHardBoundTokenTypes in Builder constructor + use toBuilde…
rmehta19 52ef3de
Merge branch 'main' into mtls-s2a-hard-binding
rmehta19 50d3ae2
Merge branch 'main' into mtls-s2a-hard-binding
rmehta19 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a thought (nothing that needs to be changed in this PR): With how many helper methods we have for S2A and hard bound tokens, I wonder if we can split these methods into a helper class in Gax-Grpc (something like S2AMtlsContext or something)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think this would be help to reduce the complexity in the
InstantiatingGrpcChannelProvider
file. I'm happy to do the cleanup of that in a followup CL.