-
Notifications
You must be signed in to change notification settings - Fork 18
feat: added confidence score and detected languages to Page
classes
#387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Shifat7
wants to merge
6
commits into
googleapis:main
Choose a base branch
from
Shifat7:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holtskinner
requested changes
Apr 29, 2025
hi @holtskinner, I've moved it to the _BasePageElement, thanks for your prompt review! |
holtskinner
reviewed
Apr 29, 2025
holtskinner
reviewed
Apr 29, 2025
hi @holtskinner , Ive removed the test samples as reviewed and other changes as well. Let me know if there's anything else |
holtskinner
requested changes
Apr 30, 2025
hi @holtskinner , all done thanks for reviewing! |
holtskinner
approved these changes
May 5, 2025
Page
classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
confidence
property to represent the confidence score of Token detection.detected_languages
property to provide a list of detected languages for each Token.Fixes #375 @sarath-mec 🦕