Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updates noxfile with pip freeze and pandas 1.2 #331

Merged
merged 1 commit into from
Mar 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions noxfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ def lint(session):
serious code quality issues.
"""
session.install(FLAKE8_VERSION, BLACK_VERSION)
session.run("python", "-m", "pip", "freeze")
session.run(
"black",
"--check",
Expand All @@ -100,6 +101,7 @@ def lint(session):
def blacken(session):
"""Run black. Format code to uniform standard."""
session.install(BLACK_VERSION)
session.run("python", "-m", "pip", "freeze")
session.run(
"black",
*LINT_PATHS,
Expand All @@ -115,6 +117,7 @@ def format(session):
session.install(BLACK_VERSION, ISORT_VERSION)
# Use the --fss option to sort imports using strict alphabetical order.
# See https://pycqa.github.io/isort/docs/configuration/options.html#force-sort-within-sections
session.run("python", "-m", "pip", "freeze")
session.run(
"isort",
"--fss",
Expand All @@ -130,6 +133,7 @@ def format(session):
def lint_setup_py(session):
"""Verify that setup.py is valid (including RST check)."""
session.install("docutils", "pygments")
session.run("python", "-m", "pip", "freeze")
session.run("python", "setup.py", "check", "--restructuredtext", "--strict")


Expand Down Expand Up @@ -169,6 +173,8 @@ def default(session, tests_path):
)
install_unittest_dependencies(session, "-c", constraints_path)

session.run("python", "-m", "pip", "freeze")

# Run py.test against the unit tests.
session.run(
"py.test",
Expand Down Expand Up @@ -342,6 +348,8 @@ def system(session):

install_systemtest_dependencies(session, "-c", constraints_path)

session.run("python", "-m", "pip", "freeze")

# Run py.test against the system tests.
if system_test_exists:
session.run(
Expand Down Expand Up @@ -371,6 +379,8 @@ def cover(session):
test runs (not system test runs), and then erases coverage data.
"""
session.install("coverage", "pytest-cov")
session.run("python", "-m", "pip", "freeze")

session.run("coverage", "report", "--show-missing", "--fail-under=100")

session.run("coverage", "erase")
Expand All @@ -397,6 +407,7 @@ def docs(session):
)

shutil.rmtree(os.path.join("docs", "_build"), ignore_errors=True)
session.run("python", "-m", "pip", "freeze")
session.run(
"sphinx-build",
"-W", # warnings as errors
Expand Down Expand Up @@ -432,6 +443,7 @@ def docfx(session):
)

shutil.rmtree(os.path.join("docs", "_build"), ignore_errors=True)
session.run("python", "-m", "pip", "freeze")
session.run(
"sphinx-build",
"-T", # show full traceback on exception
Expand Down Expand Up @@ -515,6 +527,7 @@ def prerelease_deps(session):
"requests",
]
session.install(*other_deps)
session.run("python", "-m", "pip", "freeze")

# Print out prerelease package versions
session.run(
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@

dependencies = [
"packaging >= 17.0",
"pandas >= 0.24.2",
"pandas >= 1.2.0",
"pyarrow>=3.0.0",
"numpy >= 1.16.6",
]
Expand Down
3 changes: 1 addition & 2 deletions testing/constraints-3.7.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#
# e.g., if setup.py has "foo >= 1.14.0, < 2.0.0dev",
packaging==17.0
# Make sure we test with pandas 0.24.2. The Python version isn't that relevant.
pandas==0.24.2
pandas==1.2.0
pyarrow==3.0.0
numpy==1.16.6