fix: avoid blocking in download thread when using BQ Storage API #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
Linchin
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
kien-truong
force-pushed
the
fix-bq-storage-client-deadlock
branch
from
256b0f7
to
3f8bd10
Compare
|
Just dropping by to see if there's any concerns about this PR. |
This prevents a deadlock between the main thead and download threads when the threadpool is shutdown prematurely.
kien-truong
force-pushed
the
fix-bq-storage-client-deadlock
branch
from
d3f2f1e
to
8eebb9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents a deadlock between the main thead and download threads when the threadpool is shutdown prematurely.
Fixes #2032 🦕