Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AsyncClient for async query_and_wait for BQ jobs #1839

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

kiraksi
Copy link
Contributor

@kiraksi kiraksi commented Mar 4, 2024

This PR:

  • Instantiates the an asynchronous client specifically for an asynchronous AsyncClient.query_and_wait method, including asynchronous job helpers
  • Makes a test suite for asynchronous method
  • Benchmarks this method against Client.query_and_wait and Client.query

TO DO:

  • [] Pass all tests
  • [] Create samples for this method for user understanding of how to use AsyncClient
  • [] Create separate PRs for other async RPC methods (get_job)

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #18 🦕

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery API. labels Mar 4, 2024
@kiraksi
Copy link
Contributor Author

kiraksi commented Mar 6, 2024

#1809 needs to be merged as aiohttp is a extra of google-auth which needs to be added as a direct dependency. Also see: googleapis/google-auth-library-python#613 for google-auth exposure of transport.aiohttp_requests

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQuery: make jobs awaitable
1 participant