ci: should not fail on 403/429 docs links #1581
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
| ], | ||
| "statusCodes": { | ||
| "403": "warn", | ||
| "429": "warn" |
There was a problem hiding this comment.
I think 429 shouldn't be an issue JustinBeckwith/linkinator#681
Contributor
Author
There was a problem hiding this comment.
good point. But ugh, linkinator v7 requires Node 20, I was testing locally with Node 20 and thought that was finally gonna solve this issue, but we are on Node 18 yet. 😢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linkinator now supports custom error handling on status codes. Since our docs ci step have been failing due to 403 and 429 errors, I moved then to be a warning.