feat: Adding API for AbortMultipartUpload. #3361
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
BenWhitehead
requested changes
Oct 23, 2025
| */ | ||
| @BetaApi | ||
| public abstract AbortMultipartUploadResponse abortMultipartUpload( | ||
| AbortMultipartUploadRequest request) throws IOException, NoSuchAlgorithmException; |
There was a problem hiding this comment.
We should never throw a NoSuchAlgorithmException. What necessitates this being declared here?
| } | ||
|
|
||
| /** A builder for creating {@link AbortMultipartUploadRequest} instances. */ | ||
| public static class Builder { |
There was a problem hiding this comment.
Suggested change
| public static class Builder { | |
| @BetaApi | |
| public static final class Builder { |
| Map<String, String> extensionHeaders = getGenericExtensionHeader(options); | ||
|
|
||
| HttpRequest httpRequest = requestFactory.buildDeleteRequest(new GenericUrl(abortUri)); | ||
| httpRequest.getHeaders().setContentType(contentType); |
There was a problem hiding this comment.
DELETEs don't have bodies, do we need to set the content-type for GCS? If not, please remove.
| throws IOException, NoSuchAlgorithmException { | ||
|
|
||
| return retrier.run( | ||
| Retrying.alwaysRetry(), |
There was a problem hiding this comment.
Same as list, this should be options.getRetryAlgorithmManager().idempotent()
| + " <Part>\n" | ||
| + " <PartNumber>1</PartNumber>\n" | ||
| + " <ETag>\"etag\"</ETag>\n" | ||
| + " <ETag>etag</ETag>\n" |
There was a problem hiding this comment.
Can these two changes be moved back to the list PR since they're related to that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer: Support XML MPU in GCS Java SDK #3348